Skip to content

[PWGLF] Fix inelgt0 criteria - #17568

Merged
mpuccio merged 4 commits into
AliceO2Group:masterfrom
lucasjsilva:inelgt0
Aug 23, 2026
Merged

[PWGLF] Fix inelgt0 criteria#17568
mpuccio merged 4 commits into
AliceO2Group:masterfrom
lucasjsilva:inelgt0

Conversation

@lucasjsilva

@lucasjsilva lucasjsilva commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

Correction for counting tracks considering INEL > 0

@lucasjsilva
Fix inelgt0 criteria
bbe6cea 
Correction for counting tracks considering  INEL > 0
@github-actions github-actions Bot added the pwglf label Aug 23, 2026
@github-actions github-actions Bot changed the title Fix inelgt0 criteria [PWGLF] Fix inelgt0 criteria Aug 23, 2026
@github-actions

github-actions Bot commented Aug 23, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 4 warnings, 🔕 0 disabled

@alibuild

alibuild commented Aug 23, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 3fa9a86 at 2026-08-23 18:31:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 6 errors and 2 warnings.'
Found 6 errors and 2 warnings.
++ [[ 6 -gt 0 ]]
++ cat /sw/BUILD/0248527bf1455b4f9ce2b1457a6b961475e2ee7e/O2Physics-code-check/errors.txt
PWGLF/Tasks/GlobalEventProperties/studyPnch.cxx:72:10: error: variable 'axisEvent' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/GlobalEventProperties/studyPnch.cxx:73:10: error: variable 'axisVtxZ' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/GlobalEventProperties/studyPnch.cxx:74:10: error: variable 'axisEta' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/GlobalEventProperties/studyPnch.cxx:75:10: error: variable 'axisPhi' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/GlobalEventProperties/studyPnch.cxx:76:10: error: variable 'axisCollSel' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/GlobalEventProperties/studyPnch.cxx:80:8: error: constructor does not initialize these fields: pdg [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
++ [[ 2 -gt 0 ]]
++ cat /sw/BUILD/0248527bf1455b4f9ce2b1457a6b961475e2ee7e/O2Physics-code-check/warnings.txt
PWGLF/Tasks/GlobalEventProperties/studyPnch.cxx:481:23: warning: boolean expression can be simplified by DeMorgan's theorem [readability-simplify-boolean-expr]
PWGLF/Tasks/GlobalEventProperties/studyPnch.cxx:512:9: warning: do not use 'else' after 'continue' [readability-else-after-return]
++ [[ 6 -gt 0 ]]
++ exit 1
--

Full log here.

@alibuild

alibuild commented Aug 23, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for 76dff96 at 2026-08-23 18:34:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Tasks/GlobalEventProperties/studyPnch.cxx:175:36: error: 'using std::__shared_ptr_access<TH1, __gnu_cxx::_S_atomic, false, false>::element_type = class TH1' {aka 'class TH1'} has no member named 'Getevlossaxis'
ninja: build stopped: subcommand failed.

Full log here.

@alibuild

alibuild commented Aug 23, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/staging for 76dff96 at 2026-08-23 18:35:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Tasks/GlobalEventProperties/studyPnch.cxx:175:36: error: 'using std::__shared_ptr_access<TH1, __gnu_cxx::_S_atomic, false, false>::element_type = class TH1' {aka 'class TH1'} has no member named 'Getevlossaxis'
ninja: build stopped: subcommand failed.

Full log here.

@alibuild

alibuild commented Aug 23, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for d73922e at 2026-08-23 21:54:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 6 errors and 2 warnings.'
Found 6 errors and 2 warnings.
++ [[ 6 -gt 0 ]]
++ cat /sw/BUILD/1cd92748bcf9ad8e7d94d863043f8ed8c5f39741/O2Physics-code-check/errors.txt
PWGLF/Tasks/GlobalEventProperties/studyPnch.cxx:72:10: error: variable 'axisEvent' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/GlobalEventProperties/studyPnch.cxx:73:10: error: variable 'axisVtxZ' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/GlobalEventProperties/studyPnch.cxx:74:10: error: variable 'axisEta' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/GlobalEventProperties/studyPnch.cxx:75:10: error: variable 'axisPhi' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/GlobalEventProperties/studyPnch.cxx:76:10: error: variable 'axisCollSel' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/GlobalEventProperties/studyPnch.cxx:80:8: error: constructor does not initialize these fields: pdg [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
++ [[ 2 -gt 0 ]]
++ cat /sw/BUILD/1cd92748bcf9ad8e7d94d863043f8ed8c5f39741/O2Physics-code-check/warnings.txt
PWGLF/Tasks/GlobalEventProperties/studyPnch.cxx:481:23: warning: boolean expression can be simplified by DeMorgan's theorem [readability-simplify-boolean-expr]
PWGLF/Tasks/GlobalEventProperties/studyPnch.cxx:512:9: warning: do not use 'else' after 'continue' [readability-else-after-return]
++ [[ 6 -gt 0 ]]
++ exit 1
--

Full log here.

@mpuccio
mpuccio merged commit 4d048a9 into AliceO2Group:master Aug 23, 2026
13 of 14 checks passed
@lucasjsilva
lucasjsilva deleted the inelgt0 branch August 25, 2026 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mpuccio mpuccio mpuccio approved these changes
@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner
@omvazque omvazque Awaiting requested review from omvazque omvazque is a code owner
@skundu692 skundu692 Awaiting requested review from skundu692 skundu692 is a code owner
@gbencedi gbencedi Awaiting requested review from gbencedi gbencedi is a code owner
@abmodak abmodak Awaiting requested review from abmodak abmodak is a code owner

Assignees

No one assigned

Labels

pwglf

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lucasjsilva @alibuild @mpuccio